From 0d55fd8b72a5392f6a2f6f739e211425a15d4ae9 Mon Sep 17 00:00:00 2001
From: Christian Schwarz <christian@neon.tech>
Date: Fri, 13 Oct 2023 11:50:26 +0200
Subject: [PATCH] log n_attempts not as field but inside formatted string

our tracing_subscriber::fmt puts the fields after the formatted string.
We're now loging a full backtrace again => this patch avoids
scrolling down.
---
 pageserver/src/walredo.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pageserver/src/walredo.rs b/pageserver/src/walredo.rs
index 826f0601b8..fc569c474a 100644
--- a/pageserver/src/walredo.rs
+++ b/pageserver/src/walredo.rs
@@ -296,14 +296,14 @@ impl PostgresRedoManager {
             // next request will launch a new one.
             if let Err(e) = result.as_ref() {
                 error!(
-                    n_attempts,
-                    "error applying {} WAL records {}..{} ({} bytes) to base image with LSN {} to reconstruct page image at LSN {}: {:?}",
+                    "error applying {} WAL records {}..{} ({} bytes) to base image with LSN {} to reconstruct page image at LSN {} n_attempts={}: {:?}",
                     records.len(),
                     records.first().map(|p| p.0).unwrap_or(Lsn(0)),
                     records.last().map(|p| p.0).unwrap_or(Lsn(0)),
                     nbytes,
                     base_img_lsn,
                     lsn,
+                    n_attempts,
                     e,
                 );
                 // self.stdin only holds stdin & stderr as_raw_fd().