From 14a40c9ca67568beac3783f597e44990c2c9a9e4 Mon Sep 17 00:00:00 2001 From: mikecaat <35882227+mikecaat@users.noreply.github.com> Date: Wed, 22 Mar 2023 17:10:53 +0900 Subject: [PATCH] Fix minor things for the docker-compose file (#3862) * Add the REPOSITORY env to build args to avoid the following error when executing without the credentials for the repository. ``` ERROR: Service 'compute' failed to build: Head "https://369495373322.dkr.ecr.eu-central-1.amazonaws.com/v2/compute-node-v15/manifests/2221": no basic auth credentials ``` * update the tag version in the documentation to support storage broker --- docker-compose/docker-compose.yml | 1 + docs/docker.md | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docker-compose/docker-compose.yml b/docker-compose/docker-compose.yml index b24cb80ce4..4926dad932 100644 --- a/docker-compose/docker-compose.yml +++ b/docker-compose/docker-compose.yml @@ -160,6 +160,7 @@ services: build: context: ./compute_wrapper/ args: + - REPOSITORY=${REPOSITORY:-neondatabase} - COMPUTE_IMAGE=compute-node-v${PG_VERSION:-14} - TAG=${TAG:-latest} - http_proxy=$http_proxy diff --git a/docs/docker.md b/docs/docker.md index d264a1a748..704044377f 100644 --- a/docs/docker.md +++ b/docs/docker.md @@ -37,9 +37,9 @@ You can specify version of neon cluster using following environment values. - PG_VERSION: postgres version for compute (default is 14) - TAG: the tag version of [docker image](https://registry.hub.docker.com/r/neondatabase/neon/tags) (default is latest), which is tagged in [CI test](/.github/workflows/build_and_test.yml) ``` -$ cd docker-compose/docker-compose.yml +$ cd docker-compose/ $ docker-compose down # remove the conainers if exists -$ PG_VERSION=15 TAG=2221 docker-compose up --build -d # You can specify the postgres and image version +$ PG_VERSION=15 TAG=2937 docker-compose up --build -d # You can specify the postgres and image version Creating network "dockercompose_default" with the default driver Creating docker-compose_storage_broker_1 ... done (...omit...)