From 17ba30700426ffe15cb2a7955dd22f5be0aaadf3 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Fri, 26 May 2023 17:37:42 +0200 Subject: [PATCH] test_broken_timelines: regex needs changing due to changes in this PR The regex is different because tenant2 is not broken anymore with this PR, because we allow empty timeline dirs to load --- test_runner/regress/test_broken_timeline.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test_runner/regress/test_broken_timeline.py b/test_runner/regress/test_broken_timeline.py index 1ce9fd006f..2ccf87c84e 100644 --- a/test_runner/regress/test_broken_timeline.py +++ b/test_runner/regress/test_broken_timeline.py @@ -90,9 +90,8 @@ def test_broken_timeline(neon_env_builder: NeonEnvBuilder): # Second timeline has no ancestors, only the metadata file and no layer files locally, # and we don't have the remote storage enabled. It is loaded into memory, but getting # the basebackup from it will fail. - with pytest.raises( - Exception, match=f"Tenant {tenant2} will not become active. Current state: Broken" - ) as err: + # TODO this needed changing beacuse we no longer fail load if the layer map is empty. The tenant is active now but basebackup fails. + with pytest.raises(Exception, match=r".*base backup failed") as err: pg2.start() log.info(f"As expected, compute startup failed for timeline with missing layers: {err}")