From 1afc6337fb8220d33a6fc640c8704841f22bfb86 Mon Sep 17 00:00:00 2001 From: John Spray Date: Tue, 22 Aug 2023 14:06:15 +0100 Subject: [PATCH] Remove unused `num_inprogress_deletions` --- pageserver/src/tenant/remote_timeline_client.rs | 6 +----- pageserver/src/tenant/upload_queue.rs | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/pageserver/src/tenant/remote_timeline_client.rs b/pageserver/src/tenant/remote_timeline_client.rs index 909a90178a..3dc85a5bc8 100644 --- a/pageserver/src/tenant/remote_timeline_client.rs +++ b/pageserver/src/tenant/remote_timeline_client.rs @@ -1229,7 +1229,6 @@ impl RemoteTimelineClient { last_uploaded_consistent_lsn: initialized.last_uploaded_consistent_lsn, num_inprogress_layer_uploads: 0, num_inprogress_metadata_uploads: 0, - num_inprogress_deletions: 0, inprogress_tasks: HashMap::default(), queued_operations: VecDeque::default(), }; @@ -1250,9 +1249,7 @@ impl RemoteTimelineClient { // consistency check assert_eq!( - qi.num_inprogress_layer_uploads - + qi.num_inprogress_metadata_uploads - + qi.num_inprogress_deletions, + qi.num_inprogress_layer_uploads + qi.num_inprogress_metadata_uploads, qi.inprogress_tasks.len() ); @@ -1578,7 +1575,6 @@ mod tests { assert_eq!(upload_queue.queued_operations.len(), 0); assert_eq!(upload_queue.inprogress_tasks.len(), 0); assert_eq!(upload_queue.num_inprogress_layer_uploads, 0); - assert_eq!(upload_queue.num_inprogress_deletions, 0); assert_eq!( upload_queue.latest_files_changes_since_metadata_upload_scheduled, 0 diff --git a/pageserver/src/tenant/upload_queue.rs b/pageserver/src/tenant/upload_queue.rs index a2cf9d7ceb..4880b613bf 100644 --- a/pageserver/src/tenant/upload_queue.rs +++ b/pageserver/src/tenant/upload_queue.rs @@ -60,7 +60,6 @@ pub(crate) struct UploadQueueInitialized { // Breakdown of different kinds of tasks currently in-progress pub(crate) num_inprogress_layer_uploads: usize, pub(crate) num_inprogress_metadata_uploads: usize, - pub(crate) num_inprogress_deletions: usize, /// Tasks that are currently in-progress. In-progress means that a tokio Task /// has been launched for it. An in-progress task can be busy uploading, but it can @@ -118,7 +117,6 @@ impl UploadQueue { task_counter: 0, num_inprogress_layer_uploads: 0, num_inprogress_metadata_uploads: 0, - num_inprogress_deletions: 0, inprogress_tasks: HashMap::new(), queued_operations: VecDeque::new(), }; @@ -161,7 +159,6 @@ impl UploadQueue { task_counter: 0, num_inprogress_layer_uploads: 0, num_inprogress_metadata_uploads: 0, - num_inprogress_deletions: 0, inprogress_tasks: HashMap::new(), queued_operations: VecDeque::new(), };