From 1c20cea5373b41360730409e7524e1e3c5ba7502 Mon Sep 17 00:00:00 2001
From: Joonas Koivunen <joonas@neon.tech>
Date: Fri, 5 May 2023 00:54:36 +0300
Subject: [PATCH] doc: note unhandled case

---
 pageserver/src/tenant.rs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs
index c48392c637..1b93376841 100644
--- a/pageserver/src/tenant.rs
+++ b/pageserver/src/tenant.rs
@@ -1458,6 +1458,11 @@ impl Tenant {
                     Some(Ok(())) => return Ok(()),
                     Some(Err(e)) if e.is_permanent() => return Err(DeleteTimelineError::from(e)),
                     Some(Err(_retryable)) => true,
+                    // FIXME: if the task panics without getting to the send_replace, we will be
+                    // stuck here, so perhaps this should be a futures::future::Shared, only
+                    // communicate with the joinhandle return value?
+                    //
+                    // there is no test for this yet
                     None => false,
                 };