From 1c4bed27be87a8fb25fc983e5f39e5624519f95f Mon Sep 17 00:00:00 2001 From: Konstantin Knizhnik Date: Wed, 16 Apr 2025 08:20:46 +0300 Subject: [PATCH] Resolve merge conflicts --- libs/pageserver_api/src/config.rs | 1 - pageserver/src/config.rs | 11 ----------- pageserver/src/page_service.rs | 2 +- pageserver/src/tenant/timeline.rs | 4 ---- 4 files changed, 1 insertion(+), 17 deletions(-) diff --git a/libs/pageserver_api/src/config.rs b/libs/pageserver_api/src/config.rs index bf4f14fc9d..53b68afb0f 100644 --- a/libs/pageserver_api/src/config.rs +++ b/libs/pageserver_api/src/config.rs @@ -537,7 +537,6 @@ pub mod defaults { pub const DEFAULT_SSL_KEY_FILE: &str = "server.key"; pub const DEFAULT_SSL_CERT_FILE: &str = "server.crt"; - pub const DEFAULT_LAZY_SLRU_DOWNLOAD_THRESHOLD: usize = 128; } impl Default for ConfigToml { diff --git a/pageserver/src/config.rs b/pageserver/src/config.rs index f1914c4205..26ae6af70e 100644 --- a/pageserver/src/config.rs +++ b/pageserver/src/config.rs @@ -210,7 +210,6 @@ pub struct PageServerConf { /// Interpreted protocol feature: if enabled, validate that the logical WAL received from /// safekeepers does not have gaps. pub validate_wal_contiguity: bool, -<<<<<<< HEAD /// When set, the previously written to disk heatmap is loaded on tenant attach and used /// to avoid clobbering the heatmap from new, cold, attached locations. @@ -225,12 +224,6 @@ pub struct PageServerConf { /// Does not force TLS: the client negotiates TLS usage during the handshake. /// Uses key and certificate from ssl_key_file/ssl_cert_file. pub enable_tls_page_service_api: bool, - /// - /// Size of SLRU object in blocks which triggers on-demand download rarther than including it in basebackup - /// - pub lazy_slru_download_threshold: usize, -======= ->>>>>>> 1ef4316b4 (Use lazy SLRU download for all timelines is feature flag is set) } /// Token for authentication to safekeepers @@ -400,14 +393,10 @@ impl PageServerConf { get_vectored_concurrent_io, enable_read_path_debugging, validate_wal_contiguity, -<<<<<<< HEAD load_previous_heatmap, generate_unarchival_heatmap, tracing, enable_tls_page_service_api, - lazy_slru_download_threshold, -======= ->>>>>>> 1ef4316b4 (Use lazy SLRU download for all timelines is feature flag is set) } = config_toml; let mut conf = PageServerConf { diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs index 55b89ad184..894d856f83 100644 --- a/pageserver/src/page_service.rs +++ b/pageserver/src/page_service.rs @@ -2486,7 +2486,7 @@ impl PageServerHandler { prev_lsn, full_backup, replica, - lazy_slru_download, + lazy_slru_download, &ctx, ) .await diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs index ed931195a8..d62dff7758 100644 --- a/pageserver/src/tenant/timeline.rs +++ b/pageserver/src/tenant/timeline.rs @@ -2520,10 +2520,6 @@ impl Timeline { } None => false, } - - pub(crate) fn set_lazy_slru_download(&self, enabled: bool) { - self.lazy_slru_download - .store(enabled, AtomicOrdering::Relaxed); } fn get_checkpoint_distance(&self) -> u64 {