diff --git a/libs/remote_storage/src/s3_bucket.rs b/libs/remote_storage/src/s3_bucket.rs index 0cb73f73b7..3016a14ec9 100644 --- a/libs/remote_storage/src/s3_bucket.rs +++ b/libs/remote_storage/src/s3_bucket.rs @@ -378,7 +378,7 @@ impl RemoteStorage for S3Bucket { let empty = Vec::new(); let prefixes = response.common_prefixes.as_ref().unwrap_or(&empty); - tracing::info!("list: {} prefixes, {} keys", prefixes.len(), keys.len()); + tracing::debug!("list: {} prefixes, {} keys", prefixes.len(), keys.len()); for object in keys { let object_path = object.key().expect("response does not contain a key"); diff --git a/libs/utils/src/generation.rs b/libs/utils/src/generation.rs index 49e290dab8..46eadee1da 100644 --- a/libs/utils/src/generation.rs +++ b/libs/utils/src/generation.rs @@ -152,3 +152,16 @@ impl Debug for Generation { } } } + +#[cfg(test)] +mod test { + use super::*; + + #[test] + fn generation_gt() { + // Important that a None generation compares less than a valid one, during upgrades from + // pre-generation systems. + assert!(Generation::none() < Generation::new(0)); + assert!(Generation::none() < Generation::new(1)); + } +} diff --git a/pageserver/src/tenant/remote_timeline_client/download.rs b/pageserver/src/tenant/remote_timeline_client/download.rs index 3b5fe4b207..deb5ea84a8 100644 --- a/pageserver/src/tenant/remote_timeline_client/download.rs +++ b/pageserver/src/tenant/remote_timeline_client/download.rs @@ -363,7 +363,7 @@ pub(super) async fn download_index_part( None => { // Migration from legacy pre-generation state: we have a generation but no prior // attached pageservers did. Try to load from a no-generation path. - tracing::info!("No index_part.json* found"); + tracing::debug!("No index_part.json* found"); do_download_index_part( storage, tenant_shard_id,