From 1ebcb1c45b2ed84e351b9c8fd511d75f34559bbb Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Thu, 25 Jul 2024 09:05:41 +0000 Subject: [PATCH] doc: clean out FIXME we cannot protect against willful misuse. I had been thinking of witness of Attempt but ... --- pageserver/src/tenant/timeline/detach_ancestor.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/pageserver/src/tenant/timeline/detach_ancestor.rs b/pageserver/src/tenant/timeline/detach_ancestor.rs index 1970efdb8c..893ad7dbee 100644 --- a/pageserver/src/tenant/timeline/detach_ancestor.rs +++ b/pageserver/src/tenant/timeline/detach_ancestor.rs @@ -670,9 +670,6 @@ pub(super) async fn prepare( .start_new_attempt(detached) .await?; - // FIXME: is the assumption that no one else is making these changes except us strong - // enough...? need a witness in the RemoteTimelineClient api? - // // if it wasn't persistently started already, mark the ancestor detach persistently started. detached .remote_client