From 21ca0c499950f1493f48e3119674cd2ec52822dc Mon Sep 17 00:00:00 2001 From: Yuchen Liang Date: Mon, 2 Dec 2024 16:37:16 +0000 Subject: [PATCH] review: set channel buffer size to 1 Signed-off-by: Yuchen Liang --- pageserver/src/virtual_file/owned_buffers_io/write/flush.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pageserver/src/virtual_file/owned_buffers_io/write/flush.rs b/pageserver/src/virtual_file/owned_buffers_io/write/flush.rs index e77603a7ba..9ce8b311bb 100644 --- a/pageserver/src/virtual_file/owned_buffers_io/write/flush.rs +++ b/pageserver/src/virtual_file/owned_buffers_io/write/flush.rs @@ -124,7 +124,8 @@ where where B: Buffer + Send + 'static, { - let (front, back) = duplex::mpsc::channel(2); + // It is fine to buffer up to only 1 message. We only 1 message in-flight at a time. + let (front, back) = duplex::mpsc::channel(1); let join_handle = tokio::spawn(async move { FlushBackgroundTask::new(back, file, gate_guard, ctx)