From 22470ef444c2bd9dace14f8622c1c1875eb009ab Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Wed, 24 Jul 2024 13:07:00 +0000 Subject: [PATCH] test: comment --- .../regress/test_timeline_detach_ancestor.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/test_runner/regress/test_timeline_detach_ancestor.py b/test_runner/regress/test_timeline_detach_ancestor.py index 4fcac6eb53..568e6dccea 100644 --- a/test_runner/regress/test_timeline_detach_ancestor.py +++ b/test_runner/regress/test_timeline_detach_ancestor.py @@ -1050,8 +1050,18 @@ def test_sharded_tad_interleaved_after_partial_success(neon_env_builder: NeonEnv def test_retried_detach_ancestor_after_failed_reparenting(neon_env_builder: NeonEnvBuilder): """ - Using a failpoint, force the completion step of timeline ancestor detach to fail after reparenting a single timeline. - Retrying should try reparenting until all reparentings are done, all the time blocking gc. + Using a failpoint, force the completion step of timeline ancestor detach to + fail after reparenting a single timeline. + + Retrying should try reparenting until all reparentings are done, all the + time blocking gc even across restarts (first round). + + A completion failpoint is used to inhibit completion on second to last + round. + + On last round, the completion uses a path where no reparentings can happen + because original ancestor is deleted, and there is a completion to unblock + gc without restart. """ # to get the remote storage metrics