From 28acefb31f224ae20badabe0e7a5664557b563a5 Mon Sep 17 00:00:00 2001 From: Bojan Serafimov Date: Wed, 8 Jun 2022 11:50:01 -0400 Subject: [PATCH] Add todos --- Cargo.lock | 1 + control_plane/src/storage.rs | 2 +- libs/apis/Cargo.toml | 1 + libs/apis/src/import.rs | 10 ++++++++++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Cargo.lock b/Cargo.lock index ddb1267691..98812a9cdf 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -59,6 +59,7 @@ dependencies = [ name = "apis" version = "0.1.0" dependencies = [ + "anyhow", "bytes", "serde", ] diff --git a/control_plane/src/storage.rs b/control_plane/src/storage.rs index 745301e2b7..2baf496ed4 100644 --- a/control_plane/src/storage.rs +++ b/control_plane/src/storage.rs @@ -533,7 +533,7 @@ impl PageServerNode { tenant_id: ZTenantId, timeline_id: ZTimelineId, ) -> anyhow::Result<()> { - // TODO send the timeline via the "import {tenant} {timeline}" copy both API + // TODO send using apis::upload::send_basebackup Ok(()) } } diff --git a/libs/apis/Cargo.toml b/libs/apis/Cargo.toml index deae4c4a1e..de30aa5815 100644 --- a/libs/apis/Cargo.toml +++ b/libs/apis/Cargo.toml @@ -8,3 +8,4 @@ edition = "2021" [dependencies] bytes = { version = "1.0.1", features = ['serde'] } serde = { version = "1.0", features = ["derive"] } +anyhow = "1.0" diff --git a/libs/apis/src/import.rs b/libs/apis/src/import.rs index ba84ef85a1..5abaf2b3ab 100644 --- a/libs/apis/src/import.rs +++ b/libs/apis/src/import.rs @@ -1,3 +1,5 @@ +use std::path::PathBuf; + use bytes::Bytes; use serde::{Serialize, Deserialize}; @@ -13,3 +15,11 @@ pub enum ImportBeMessage { Done, Error(String), } + +// TODO add a thin binary wrapper for this function, aside from neon_local +pub fn send_basebackup(basebackup_dir: PathBuf) -> anyhow::Result<()> { + // TODO change return type + // TODO implement as sender of ImportFeMessage and receiver of ImportBeMessage + // on generic channel. + Ok(()) +}