From 2a6efe4a4840b04026fd6ba97ecbcd56268681d8 Mon Sep 17 00:00:00 2001
From: Bojan Serafimov <bojan.serafimov7@gmail.com>
Date: Tue, 22 Feb 2022 11:30:00 -0500
Subject: [PATCH] Add TODOs

---
 test_runner/fixtures/zenith_fixtures.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_runner/fixtures/zenith_fixtures.py b/test_runner/fixtures/zenith_fixtures.py
index 000a78855a..c4a21d008d 100644
--- a/test_runner/fixtures/zenith_fixtures.py
+++ b/test_runner/fixtures/zenith_fixtures.py
@@ -1168,6 +1168,7 @@ class ZenithProxy(PgProtocol):
 
         http_port = "7001"
         args = [
+            # TODO is cargo run the right thing to do?
             "cargo",
             "run",
             "--bin", "proxy",
@@ -1183,11 +1184,9 @@ class ZenithProxy(PgProtocol):
         requests.get(f"http://{self.host}:{http_port}/v1/status")
 
 
-
     def stop(self) -> None:
         assert self.running
         # print("PID: ", self.popen.pid)
-        # print(self.popen.communicate())
         self.running = False
 
         # NOTE the process will die when we're done with tests anyway, because
@@ -1201,6 +1200,7 @@ class ZenithProxy(PgProtocol):
         if self.running:
             self.stop()
 
+# TODO make this static_proxy, and increase the scope?
 @pytest.fixture(scope='function')
 def zenith_proxy() -> Iterator[ZenithProxy]:
     with ZenithProxy(4432) as proxy: