From 2afcc58ce063eab61254590717563094c05ab660 Mon Sep 17 00:00:00 2001 From: John Spray Date: Sat, 20 Jul 2024 20:27:31 +0100 Subject: [PATCH] faster vecmap appends --- pageserver/src/tenant/storage_layer/inmemory_layer.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pageserver/src/tenant/storage_layer/inmemory_layer.rs b/pageserver/src/tenant/storage_layer/inmemory_layer.rs index 53fbd8e09e..891693ce40 100644 --- a/pageserver/src/tenant/storage_layer/inmemory_layer.rs +++ b/pageserver/src/tenant/storage_layer/inmemory_layer.rs @@ -534,10 +534,9 @@ impl InMemoryLayer { for (lsn, key, _buf, off) in values.into_iter() { let vec_map = inner.index.entry(key).or_default(); - let old = vec_map.append_or_update_last(lsn, off).unwrap().0; - debug_assert!(old.is_none()); - // TODO: the vec map append has some kind of instrument() in it that probably isn't super fast + // Use fast version of append, since we know our LSNs are already sorted + vec_map.append2(lsn, off); } let size = inner.file.len();