From 2d93b129a018dc47b9e29f923a0397c545a90560 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Sat, 5 Feb 2022 17:59:31 +0200 Subject: [PATCH] Avoid eprintln() in pageserver and walkeeper. Use log::error!() instead. I spotted a few of these "connection error" lines in the logs, without timestamps and the other stuff we print for all other log messages. --- pageserver/src/walreceiver.rs | 2 +- walkeeper/src/callmemaybe.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pageserver/src/walreceiver.rs b/pageserver/src/walreceiver.rs index b6bf117a14..4421bb6752 100644 --- a/pageserver/src/walreceiver.rs +++ b/pageserver/src/walreceiver.rs @@ -160,7 +160,7 @@ fn walreceiver_main( // This is from tokio-postgres docs, but it is a bit weird in our case because we extensively use block_on runtime.spawn(async move { if let Err(e) = connection.await { - eprintln!("connection error: {}", e); + error!("connection error: {}", e); } }); diff --git a/walkeeper/src/callmemaybe.rs b/walkeeper/src/callmemaybe.rs index 49712a6bf3..1e52ec927b 100644 --- a/walkeeper/src/callmemaybe.rs +++ b/walkeeper/src/callmemaybe.rs @@ -33,7 +33,7 @@ async fn request_callback( tokio::spawn(async move { if let Err(e) = connection.await { - eprintln!("connection error: {}", e); + error!("connection error: {}", e); } });