From 2e35475c9aa6da4ee048830af80ad6faee07a161 Mon Sep 17 00:00:00 2001 From: Konstantin Knizhnik Date: Tue, 27 May 2025 11:42:29 +0300 Subject: [PATCH] Remove special implementation of pg_promote for PG14 --- pgxn/neon/walproposer_pg.c | 2 ++ test_runner/regress/test_replica_promote.py | 20 ++------------------ 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/pgxn/neon/walproposer_pg.c b/pgxn/neon/walproposer_pg.c index fc152e5a7d..3fdab359df 100644 --- a/pgxn/neon/walproposer_pg.c +++ b/pgxn/neon/walproposer_pg.c @@ -161,6 +161,8 @@ WalProposerMain(Datum main_arg) { WalProposer *wp; + walprop_shared->bgw_started = true; + while (*wal_acceptors_list == '\0') { /* Wait until wal acceptors list GUC changes are propagated */ diff --git a/test_runner/regress/test_replica_promote.py b/test_runner/regress/test_replica_promote.py index d1571a8d03..67a39159ef 100644 --- a/test_runner/regress/test_replica_promote.py +++ b/test_runner/regress/test_replica_promote.py @@ -54,24 +54,8 @@ def test_replica_promotes(neon_simple_env: NeonEnv, pg_version: PgVersion): secondary_conn = secondary.connect() secondary_cur = secondary_conn.cursor() - - if env.pg_version is PgVersion.V14: - assert secondary.pgdata_dir - signalfile = secondary.pgdata_dir / "standby.signal" - assert signalfile.exists() - signalfile.unlink() - - promoted = False - while not promoted: - with secondary.connect() as try_it: - try_cursor = try_it.cursor() - try_cursor.execute( - "SELECT setting FROM pg_settings WHERE name = 'transaction_read_only'" - ) - promoted = ("off",) == try_cursor.fetchone() - else: - secondary_cur.execute("SELECT * FROM pg_promote()") - assert secondary_cur.fetchone() == (True,) + secondary_cur.execute("SELECT * FROM pg_promote()") + assert secondary_cur.fetchone() == (True,) secondary_conn = secondary.connect() secondary_cur = secondary_conn.cursor()