From 30ea7b141b7a80be96382e3006cd0674fa2e5814 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Wed, 3 May 2023 18:39:54 +0200 Subject: [PATCH] test_delete_timeline_client_hangup: account for logging of dropped requests This must have come with the latest merge from main. --- test_runner/regress/test_remote_storage.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test_runner/regress/test_remote_storage.py b/test_runner/regress/test_remote_storage.py index 1738a60e7f..9841647bf3 100644 --- a/test_runner/regress/test_remote_storage.py +++ b/test_runner/regress/test_remote_storage.py @@ -1021,6 +1021,16 @@ def test_delete_timeline_client_hangup(neon_env_builder: NeonEnvBuilder): wait_until(50, 0.1, hit_failpoint) + # we log this error if a client hangs up + # might as well use it as another indicator that the test works + hangup_log_message = f".*DELETE.*{child_timeline_id}.*request was dropped before completing" + env.pageserver.allowed_errors.append(hangup_log_message) + + def got_hangup_log_message(): + assert env.pageserver.log_contains(hangup_log_message) + + wait_until(50, 0.1, got_hangup_log_message) + # ok, retry without failpoint, it should succeed ps_http.configure_failpoints((failpoint_name, "off"))