diff --git a/pageserver/src/tenant/storage_layer.rs b/pageserver/src/tenant/storage_layer.rs index 5ddead45c2..ef40cb4258 100644 --- a/pageserver/src/tenant/storage_layer.rs +++ b/pageserver/src/tenant/storage_layer.rs @@ -363,9 +363,6 @@ pub trait Layer: std::fmt::Debug + std::fmt::Display + Send + Sync + 'static { reconstruct_data: &mut ValueReconstructState, ctx: &RequestContext, ) -> Result; - - /// Dump summary of the contents of the layer to stdout - async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()>; } /// Get a layer descriptor from a layer. diff --git a/pageserver/src/tenant/storage_layer/delta_layer.rs b/pageserver/src/tenant/storage_layer/delta_layer.rs index 0c1180554d..0e3333f057 100644 --- a/pageserver/src/tenant/storage_layer/delta_layer.rs +++ b/pageserver/src/tenant/storage_layer/delta_layer.rs @@ -239,11 +239,6 @@ impl std::fmt::Debug for DeltaLayerInner { #[async_trait::async_trait] impl Layer for DeltaLayer { - /// debugging function to print out the contents of the layer - async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> { - self.dump(verbose, ctx).await - } - async fn get_value_reconstruct_data( &self, key: Key, diff --git a/pageserver/src/tenant/storage_layer/image_layer.rs b/pageserver/src/tenant/storage_layer/image_layer.rs index 4596e7ba9d..b2d8bde8db 100644 --- a/pageserver/src/tenant/storage_layer/image_layer.rs +++ b/pageserver/src/tenant/storage_layer/image_layer.rs @@ -169,11 +169,6 @@ impl std::fmt::Debug for ImageLayerInner { #[async_trait::async_trait] impl Layer for ImageLayer { - /// debugging function to print out the contents of the layer - async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> { - self.dump(verbose, ctx).await - } - /// Look up given page in the file async fn get_value_reconstruct_data( &self, diff --git a/pageserver/src/tenant/storage_layer/inmemory_layer.rs b/pageserver/src/tenant/storage_layer/inmemory_layer.rs index b639852e9f..f8d47124cc 100644 --- a/pageserver/src/tenant/storage_layer/inmemory_layer.rs +++ b/pageserver/src/tenant/storage_layer/inmemory_layer.rs @@ -223,10 +223,6 @@ impl Layer for InMemoryLayer { self.get_value_reconstruct_data(key, lsn_range, reconstruct_data, ctx) .await } - - async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> { - self.dump(verbose, ctx).await - } } impl std::fmt::Display for InMemoryLayer { diff --git a/pageserver/src/tenant/storage_layer/remote_layer.rs b/pageserver/src/tenant/storage_layer/remote_layer.rs index f1bdcc18eb..9de13b4af3 100644 --- a/pageserver/src/tenant/storage_layer/remote_layer.rs +++ b/pageserver/src/tenant/storage_layer/remote_layer.rs @@ -76,24 +76,6 @@ impl Layer for RemoteLayer { ) -> Result { bail!("layer {self} needs to be downloaded"); } - - /// debugging function to print out the contents of the layer - async fn dump(&self, _verbose: bool, _ctx: &RequestContext) -> Result<()> { - println!( - "----- remote layer for ten {} tli {} keys {}-{} lsn {}-{} is_delta {} is_incremental {} size {} ----", - self.desc.tenant_id, - self.desc.timeline_id, - self.desc.key_range.start, - self.desc.key_range.end, - self.desc.lsn_range.start, - self.desc.lsn_range.end, - self.desc.is_delta, - self.desc.is_incremental, - self.desc.file_size, - ); - - Ok(()) - } } /// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.