From 315be6a66487185af114c972b4595189fc8c8bfa Mon Sep 17 00:00:00 2001
From: Konstantin Knizhnik <knizhnik@neon.tech>
Date: Tue, 2 Apr 2024 17:04:21 +0300
Subject: [PATCH] Restore running xacts from CLOG on replica startup

---
 pageserver/src/walingest.rs                   | 1 +
 test_runner/regress/test_replication_start.py | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/pageserver/src/walingest.rs b/pageserver/src/walingest.rs
index 79f075b877..bc6116b82b 100644
--- a/pageserver/src/walingest.rs
+++ b/pageserver/src/walingest.rs
@@ -373,6 +373,7 @@ impl WalIngest {
                 if info == pg_constants::XLOG_RUNNING_XACTS {
                     let xlrec = crate::walrecord::XlRunningXacts::decode(&mut buf);
                     self.checkpoint.oldestActiveXid = xlrec.oldest_running_xid;
+                    self.checkpoint_modified = true;
                 }
             }
             _x => {
diff --git a/test_runner/regress/test_replication_start.py b/test_runner/regress/test_replication_start.py
index 2360745990..b4699c7be8 100644
--- a/test_runner/regress/test_replication_start.py
+++ b/test_runner/regress/test_replication_start.py
@@ -1,9 +1,7 @@
-import pytest
 from fixtures.log_helper import log
 from fixtures.neon_fixtures import NeonEnv, wait_replica_caughtup
 
 
-@pytest.mark.xfail
 def test_replication_start(neon_simple_env: NeonEnv):
     env = neon_simple_env