From 3375f289902261dd9d1c58fb3c32add28d081341 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 21 Nov 2024 11:21:50 +0100 Subject: [PATCH] pytest.approx; https://github.com/neondatabase/neon/pull/9820#discussion_r1850679974 --- .../pageserver/test_pageserver_getpage_merge.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test_runner/performance/pageserver/test_pageserver_getpage_merge.py b/test_runner/performance/pageserver/test_pageserver_getpage_merge.py index c8522af476..272446b73c 100644 --- a/test_runner/performance/pageserver/test_pageserver_getpage_merge.py +++ b/test_runner/performance/pageserver/test_pageserver_getpage_merge.py @@ -176,11 +176,10 @@ def test_getpage_merge_smoke( # # Sanity-checks on the collected data # - def close_enough(a, b): - return (a / b > 0.99 and a / b < 1.01) and (b / a > 0.99 and b / a < 1.01) - # assert that getpage counts roughly match between compute and ps - assert close_enough(metrics.pageserver_getpage_count, metrics.compute_getpage_count) + assert metrics.pageserver_getpage_count == pytest.approx( + metrics.compute_getpage_count, rel=0.01 + ) # # Record the results