From 361210f8dc670125f36e751f3fa558ed1e4e6b0e Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Tue, 21 Jan 2025 21:27:21 +0100 Subject: [PATCH] actually enable concurrent IO (and batching!) by default in test suite (still need to figure out how to not make compat test break) https://neondb.slack.com/archives/C059ZC138NR/p1737490501941309 --- test_runner/fixtures/neon_fixtures.py | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index 83d72b76af..3c7b344d99 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -1124,22 +1124,19 @@ class NeonEnv: # Batching (https://github.com/neondatabase/neon/issues/9377): # enable batching by default in tests and benchmarks. - # Compat tests are exempt because old versions fail to parse the new config. - if not config.compatibility_neon_binpath: - ps_cfg["page_service_pipelining"] = { - "mode": "pipelined", - "execution": "concurrent-futures", - "max_batch_size": 32, - } + ps_cfg["page_service_pipelining"] = { + "mode": "pipelined", + "execution": "concurrent-futures", + "max_batch_size": 32, + } # Concurrent IO (https://github.com/neondatabase/neon/issues/9378): # enable concurrent IO by default in tests and benchmarks. # Compat tests are exempt because old versions fail to parse the new config. - if not config.compatibility_neon_binpath: - if self.pageserver_get_vectored_concurrent_io is not None: - ps_cfg["get_vectored_concurrent_io"] = { - "mode": self.pageserver_get_vectored_concurrent_io, - } + if self.pageserver_get_vectored_concurrent_io is not None: + ps_cfg["get_vectored_concurrent_io"] = { + "mode": self.pageserver_get_vectored_concurrent_io, + } if self.pageserver_virtual_file_io_engine is not None: ps_cfg["virtual_file_io_engine"] = self.pageserver_virtual_file_io_engine