From 37258159354433564df273fe50bb3e16e2c8e875 Mon Sep 17 00:00:00 2001
From: Eric Seppanen <eds@reric.net>
Date: Sun, 18 Apr 2021 22:34:01 -0700
Subject: [PATCH] pageserver: propage errors instead of calling .unwrap()

Just a few more places where we can drop the .unwrap() call in favor of
`?`.

Also include a fix to the log file handling: don't open the file twice.
Writing to two fds would result in one message overwriting another.
Presumably `File.try_clone()` reduces down to `dup` on Linux.
---
 pageserver/src/bin/pageserver.rs | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/pageserver/src/bin/pageserver.rs b/pageserver/src/bin/pageserver.rs
index 7419e3f894..0ef258ad6c 100644
--- a/pageserver/src/bin/pageserver.rs
+++ b/pageserver/src/bin/pageserver.rs
@@ -8,11 +8,11 @@ use std::io;
 use std::path::PathBuf;
 use std::process::exit;
 use std::thread;
-use std::{fs::File, fs::OpenOptions, str::FromStr};
+use std::{fs::File, fs::OpenOptions};
 
+use anyhow::{Context, Result};
 use clap::{App, Arg};
 use daemonize::Daemonize;
-use anyhow::Result;
 
 use slog::Drain;
 
@@ -88,11 +88,11 @@ fn main() -> Result<()> {
     }
 
     if let Some(addr) = arg_matches.value_of("wal_producer") {
-        conf.wal_producer_connstr = Some(String::from_str(addr).unwrap());
+        conf.wal_producer_connstr = Some(String::from(addr));
     }
 
     if let Some(addr) = arg_matches.value_of("listen") {
-        conf.listen_addr = addr.parse().unwrap();
+        conf.listen_addr = addr.parse()?;
     }
 
     start_pageserver(&conf)
@@ -101,7 +101,7 @@ fn main() -> Result<()> {
 fn start_pageserver(conf: &PageServerConf) -> Result<()> {
     // Initialize logger
     let _scope_guard = init_logging(&conf)?;
-    let _log_guard = slog_stdlog::init().unwrap();
+    let _log_guard = slog_stdlog::init()?;
 
     // Note: this `info!(...)` macro comes from `log` crate
     info!("standard logging redirected to slog");
@@ -125,18 +125,15 @@ fn start_pageserver(conf: &PageServerConf) -> Result<()> {
     if conf.daemonize {
         info!("daemonizing...");
 
-        // There should'n be any logging to stdin/stdout. Redirect it to the main log so
-        // that we will see any accidental manual fpritf's or backtraces.
+        // There shouldn't be any logging to stdin/stdout. Redirect it to the main log so
+        // that we will see any accidental manual fprintf's or backtraces.
+        let log_filename = conf.data_dir.join("pageserver.log");
         let stdout = OpenOptions::new()
             .create(true)
             .append(true)
-            .open(conf.data_dir.join("pageserver.log"))
-            .unwrap();
-        let stderr = OpenOptions::new()
-            .create(true)
-            .append(true)
-            .open(conf.data_dir.join("pageserver.log"))
-            .unwrap();
+            .open(&log_filename)
+            .with_context(|| format!("failed to open {:?}", log_filename))?;
+        let stderr = stdout.try_clone()?;
 
         let daemonize = Daemonize::new()
             .pid_file(conf.data_dir.join("pageserver.pid"))