From 3784166180026cdc5e8fc4df0e96faaf33a0904b Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Wed, 10 May 2023 16:53:03 +0300 Subject: [PATCH] doc: more cleanup --- pageserver/src/tenant.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index a963911295..6b79dc313c 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -1508,6 +1508,12 @@ impl Tenant { // FIXME: simplify uploading // if we have concurrent requests, we will only execute one version of following future; // initially it did not have any means to be cancelled. + // + // NOTE: Unlike "the usual" futures, this one will log any errors instead of just propagating + // them to the caller. This is because this one future produces a value, which will need to + // be cloneable to everyone interested, and normal `std::error::Error` are not clonable. + // Also, it wouldn't make sense to log the same failure multiple times, it would look like + // multiple failures to anyone reading the logs. let factory = || { let tenant = self.clone(); let tenant_id = self.tenant_id; @@ -1541,8 +1547,6 @@ impl Tenant { } // Stop & wait for the remaining timeline tasks, including upload tasks. - // NB: This and other delete_timeline calls do not run as a task_mgr task, - // so, they are not affected by this shutdown_tasks() call. info!("waiting for timeline tasks to shutdown"); task_mgr::shutdown_tasks(None, Some(tenant_id), Some(timeline_id)).await;