From 3b88998f8eea8c44aabac8795542280ede74e243 Mon Sep 17 00:00:00 2001 From: Yuchen Liang Date: Fri, 18 Oct 2024 17:53:49 +0000 Subject: [PATCH] review: clarify IoBuf safety comments Signed-off-by: Yuchen Liang --- .../owned_buffers_io/aligned_buffer/buffer_mut.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pageserver/src/virtual_file/owned_buffers_io/aligned_buffer/buffer_mut.rs b/pageserver/src/virtual_file/owned_buffers_io/aligned_buffer/buffer_mut.rs index c878ab14f8..00dbf28bd9 100644 --- a/pageserver/src/virtual_file/owned_buffers_io/aligned_buffer/buffer_mut.rs +++ b/pageserver/src/virtual_file/owned_buffers_io/aligned_buffer/buffer_mut.rs @@ -209,7 +209,9 @@ fn panic_advance(idx: usize, len: usize) -> ! { } /// Safety: [`AlignedBufferMut`] has exclusive ownership of the io buffer, -/// and the location remains stable even if [`Self`] is moved. +/// and the underlying pointer remains stable while io-uring is owning the buffer. +/// The tokio-epoll-uring crate itself will not resize the buffer and will respect +/// [`IoBuf::bytes_total`]. unsafe impl tokio_epoll_uring::IoBuf for AlignedBufferMut { fn stable_ptr(&self) -> *const u8 { self.as_ptr()