diff --git a/pgxn/neon/libpagestore.c b/pgxn/neon/libpagestore.c index d7507e69df..df92a1e2f4 100644 --- a/pgxn/neon/libpagestore.c +++ b/pgxn/neon/libpagestore.c @@ -92,11 +92,10 @@ pageserver_connect() while (PQisBusy(pageserver_conn)) { - int wc; WaitEvent event; /* Sleep until there's something to do */ - wc = WaitEventSetWait(pageserver_conn_wes, -1L, &event, 1, PG_WAIT_EXTENSION); + (void) WaitEventSetWait(pageserver_conn_wes, -1L, &event, 1, PG_WAIT_EXTENSION); ResetLatch(MyLatch); CHECK_FOR_INTERRUPTS(); @@ -136,11 +135,10 @@ retry: if (ret == 0) { - int wc; WaitEvent event; /* Sleep until there's something to do */ - wc = WaitEventSetWait(pageserver_conn_wes, -1L, &event, 1, PG_WAIT_EXTENSION); + (void) WaitEventSetWait(pageserver_conn_wes, -1L, &event, 1, PG_WAIT_EXTENSION); ResetLatch(MyLatch); CHECK_FOR_INTERRUPTS(); diff --git a/pgxn/neon/pagestore_smgr.c b/pgxn/neon/pagestore_smgr.c index d9b45e3933..21067fb56f 100644 --- a/pgxn/neon/pagestore_smgr.c +++ b/pgxn/neon/pagestore_smgr.c @@ -1649,7 +1649,8 @@ neon_close(SMgrRelation reln, ForkNumber forknum) bool neon_prefetch(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum) { - uint64 ring_index PG_USED_FOR_ASSERTS_ONLY; + BufferTag tag; + uint64 ring_index PG_USED_FOR_ASSERTS_ONLY; switch (reln->smgr_relpersistence) { @@ -1665,7 +1666,7 @@ neon_prefetch(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum) elog(ERROR, "unknown relpersistence '%c'", reln->smgr_relpersistence); } - BufferTag tag = (BufferTag) { + tag = (BufferTag) { .rnode = reln->smgr_rnode.node, .forkNum = forknum, .blockNum = blocknum diff --git a/pgxn/neon/walproposer.c b/pgxn/neon/walproposer.c index c24142dca1..8323811b0d 100644 --- a/pgxn/neon/walproposer.c +++ b/pgxn/neon/walproposer.c @@ -119,6 +119,7 @@ static TimestampTz last_reconnect_attempt; static WalproposerShmemState * walprop_shared; /* Prototypes for private functions */ +static void WalProposerRegister(void); static void WalProposerInit(XLogRecPtr flushRecPtr, uint64 systemId); static void WalProposerStart(void); static void WalProposerLoop(void); @@ -455,7 +456,7 @@ WalProposerPoll(void) /* * Register a background worker proposing WAL to wal acceptors. */ -void +static void WalProposerRegister(void) { BackgroundWorker bgw; diff --git a/pgxn/neon/walproposer.h b/pgxn/neon/walproposer.h index 3c4f080353..362b194b32 100644 --- a/pgxn/neon/walproposer.h +++ b/pgxn/neon/walproposer.h @@ -377,18 +377,18 @@ typedef struct Safekeeper AppendResponse appendResponse; /* feedback for master */ } Safekeeper; -extern PGDLLIMPORT void WalProposerMain(Datum main_arg); -void WalProposerBroadcast(XLogRecPtr startpos, XLogRecPtr endpos); -void WalProposerPoll(void); -void WalProposerRegister(void); -void ParseReplicationFeedbackMessage(StringInfo reply_message, - ReplicationFeedback * rf); +extern void WalProposerSync(int argc, char *argv[]); +extern void WalProposerMain(Datum main_arg); +extern void WalProposerBroadcast(XLogRecPtr startpos, XLogRecPtr endpos); +extern void WalProposerPoll(void); +extern void ParseReplicationFeedbackMessage(StringInfo reply_message, + ReplicationFeedback *rf); extern void StartProposerReplication(StartReplicationCmd *cmd); -Size WalproposerShmemSize(void); -bool WalproposerShmemInit(void); -void replication_feedback_set(ReplicationFeedback * rf); -void replication_feedback_get_lsns(XLogRecPtr *writeLsn, XLogRecPtr *flushLsn, XLogRecPtr *applyLsn); +extern Size WalproposerShmemSize(void); +extern bool WalproposerShmemInit(void); +extern void replication_feedback_set(ReplicationFeedback *rf); +extern void replication_feedback_get_lsns(XLogRecPtr *writeLsn, XLogRecPtr *flushLsn, XLogRecPtr *applyLsn); /* libpqwalproposer hooks & helper type */