From 44466cebdb5a072ec8076a655c4c25a0fdecc014 Mon Sep 17 00:00:00 2001
From: Christian Schwarz <christian@neon.tech>
Date: Sat, 26 Jul 2025 17:21:25 +0200
Subject: [PATCH] WIP better observability for return values (SystemTime Debug
 is useless)

---
 pageserver/src/page_service.rs    | 7 +++++--
 pageserver/src/tenant/timeline.rs | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs
index 85c98e37d4..fc8263e3c1 100644
--- a/pageserver/src/page_service.rs
+++ b/pageserver/src/page_service.rs
@@ -2264,9 +2264,12 @@ impl PageServerHandler {
         set_tracing_field_shard_id(&timeline);
 
         let result: Option<SystemTime> = timeline
-            .lease_standby_horizon(lease_id, lsn, ctx)
-            // logging happens inside
+            .lease_standby_horizon(lease_id, lsn, ctx) // logs errors internally
             .ok();
+        debug!(
+            result = result.map(|x| chrono::DateTime::<Utc>::from(x).to_rfc3339()),
+            "result"
+        ); // XXX better observability isn't great
 
         // Encode result as Option<millis since epoch>
         let bytes = result.map(|t| {
diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs
index 36230699cc..3334791c43 100644
--- a/pageserver/src/tenant/timeline.rs
+++ b/pageserver/src/tenant/timeline.rs
@@ -1867,7 +1867,8 @@ impl Timeline {
         Ok(lease)
     }
 
-    #[instrument(skip(_ctx), ret(Debug), err(Debug))]
+    /// Logs return value at info level and errors at warn level in Debug::fmt.
+    #[instrument(skip(_ctx), ret(level = tracing::Level::INFO, Debug), err(level = tracing::Level::WARN, Debug))]
     pub(crate) fn lease_standby_horizon(
         &self,
         lease_id: String,