From 45b558f480e76f46a61eb97504931c8bd211457b Mon Sep 17 00:00:00 2001 From: Peter Bendel Date: Tue, 29 Oct 2024 11:53:28 +0100 Subject: [PATCH] temporarily increase timeout for clickbench benchmark until regression is resolved (#9554) ## Problem click bench job in benchmarking workflow has a performance regression causing it to run in timeout of max job run. Suspected root cause: Project has been migrated from single pageserver to storage controller managed project on Oct 14th. Since then the regression shows. ## Summary of changes Increase timeout of pytest to 12 hours. Increase job timeout to 12 hours --- .github/workflows/benchmarking.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarking.yml b/.github/workflows/benchmarking.yml index 5ccfe48684..69b8bc5d70 100644 --- a/.github/workflows/benchmarking.yml +++ b/.github/workflows/benchmarking.yml @@ -671,6 +671,10 @@ jobs: password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }} options: --init + # Increase timeout to 12h, default timeout is 6h + # we have regression in clickbench causing it to run 2-3x longer + timeout-minutes: 720 + steps: - uses: actions/checkout@v4 @@ -716,7 +720,7 @@ jobs: test_selection: performance/test_perf_olap.py run_in_parallel: false save_perf_report: ${{ env.SAVE_PERF_REPORT }} - extra_params: -m remote_cluster --timeout 21600 -k test_clickbench + extra_params: -m remote_cluster --timeout 43200 -k test_clickbench pg_version: ${{ env.DEFAULT_PG_VERSION }} env: VIP_VAP_ACCESS_TOKEN: "${{ secrets.VIP_VAP_ACCESS_TOKEN }}"