From 4608b1ec7019620ef3d63e95cacfd590523be56d Mon Sep 17 00:00:00 2001 From: Stas Kelvich Date: Fri, 28 May 2021 10:41:16 +0300 Subject: [PATCH] Set wal_log_hints=on That is mandatory to correctly maintain visibility map (see issue#192). It also makes sense to check that wal_log_hints is enabled at the pageserver side, but for now let just check that tests will pass with this on. --- control_plane/src/compute.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/control_plane/src/compute.rs b/control_plane/src/compute.rs index 7192e9117a..452f64b5b5 100644 --- a/control_plane/src/compute.rs +++ b/control_plane/src/compute.rs @@ -301,11 +301,13 @@ impl PostgresNode { ar.unpack(&pgdata) .with_context(|| "extracting page backup failed")?; - // listen for selected port + // wal_log_hints is mandatory when running against pageserver (see gh issue#192) + // TODO: is it possible to check wal_log_hints at pageserver side via XLOG_PARAMETER_CHANGE? self.append_conf( "postgresql.conf", &format!( "max_wal_senders = 10\n\ + wal_log_hints = on\n\ max_replication_slots = 10\n\ hot_standby = on\n\ shared_buffers = 1MB\n\