From 4973419a38336757fe5210112f0b57dd7a3896e5 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Tue, 29 Aug 2023 11:06:12 +0300 Subject: [PATCH] doc: cancellation safety with evict_and_wait --- pageserver/src/tenant/storage_layer/layer.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pageserver/src/tenant/storage_layer/layer.rs b/pageserver/src/tenant/storage_layer/layer.rs index 533e303242..9929a39056 100644 --- a/pageserver/src/tenant/storage_layer/layer.rs +++ b/pageserver/src/tenant/storage_layer/layer.rs @@ -166,7 +166,8 @@ impl Layer { /// If for a bad luck or blocking of the executor, we miss the actual eviction and the layer is /// re-downloaded, [`EvictionError::Downloaded`] is returned. /// - /// Cancellation safe. + /// Technically cancellation safe, but cancelling might shift the viewpoint of what generation + /// of download-evict cycle on retry. pub(crate) async fn evict_and_wait( &self, rtc: &RemoteTimelineClient,