From 4a562dff2e8f55571521634f596f77f438230459 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Wed, 17 Jul 2024 13:03:34 +0000 Subject: [PATCH] doc: more --- pageserver/src/tenant.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index d3b53baf55..3ea4941f6e 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -300,7 +300,10 @@ pub struct Tenant { pub(crate) timeline_get_throttle: Arc>, - /// An ongoing timeline detach must be checked during attempts to GC or compact a timeline. + /// An ongoing timeline detach must be checked during attempts to GC a timeline. + /// + /// After starting the timeline detach ancestor, blocking GC until it completes allows retrying + /// the ancestor detach, until we can be certain that all reparentings have been done. ongoing_timeline_detach: std::sync::Mutex>, l0_flush_global_state: L0FlushGlobalState,