From 4b358f6a3c60b809aa2ff0a2672aa20a5197368a Mon Sep 17 00:00:00 2001
From: Yuchen Liang <yuchen@neon.tech>
Date: Wed, 11 Dec 2024 18:34:01 +0000
Subject: [PATCH] review: proper error handling for
 OwnedAsyncWriter::write_all_at

https://github.com/neondatabase/neon/pull/10063#discussion_r1880439513

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
---
 pageserver/src/virtual_file.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pageserver/src/virtual_file.rs b/pageserver/src/virtual_file.rs
index b6ccce8453..8c03f97a98 100644
--- a/pageserver/src/virtual_file.rs
+++ b/pageserver/src/virtual_file.rs
@@ -1332,8 +1332,8 @@ impl OwnedAsyncWriter for VirtualFile {
         ctx: &RequestContext,
     ) -> std::io::Result<FullSlice<Buf>> {
         let (buf, res) = VirtualFile::write_all_at(self, buf, offset, ctx).await;
-        let x = res.map(|_| buf).unwrap();
-        Ok(x)
+        res?;
+        Ok(buf)
     }
 }