From 4ba783d0af84c773317476e96d93f66a2e9e7e7c Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Wed, 3 Nov 2021 19:10:23 +0200 Subject: [PATCH] Remove a couple of unused functions. We might want to have custom serialize/deserialize functions for WALRecords and PageVersions for performance reasons, see github issue 832. But that would probably look a bit different from this, and currently these functions are just dead. --- pageserver/src/repository.rs | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/pageserver/src/repository.rs b/pageserver/src/repository.rs index c925c45200..66d930bb85 100644 --- a/pageserver/src/repository.rs +++ b/pageserver/src/repository.rs @@ -1,7 +1,7 @@ use crate::relish::*; use crate::CheckpointConfig; use anyhow::Result; -use bytes::{Buf, BufMut, Bytes, BytesMut}; +use bytes::Bytes; use serde::{Deserialize, Serialize}; use std::collections::HashSet; use std::ops::{AddAssign, Deref}; @@ -202,28 +202,9 @@ pub struct WALRecord { pub main_data_offset: u32, } -impl WALRecord { - pub fn pack(&self, buf: &mut BytesMut) { - buf.put_u8(self.will_init as u8); - buf.put_u32(self.main_data_offset); - buf.put_u32(self.rec.len() as u32); - buf.put_slice(&self.rec[..]); - } - pub fn unpack(buf: &mut Bytes) -> WALRecord { - let will_init = buf.get_u8() != 0; - let main_data_offset = buf.get_u32(); - let rec_len = buf.get_u32() as usize; - let rec = buf.split_to(rec_len); - WALRecord { - will_init, - rec, - main_data_offset, - } - } -} - #[cfg(test)] pub mod repo_harness { + use bytes::BytesMut; use std::{fs, path::PathBuf}; use crate::{