From 4e4bc8fbde726594807cfb9169bab5f631554b59 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Fri, 25 Nov 2022 08:45:28 -0500 Subject: [PATCH] Tenant::load remove obsolete FIXME, add .with_context(): see https://github.com/neondatabase/neon/pull/2785#discussion_r1030581703 --- pageserver/src/tenant.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index 8b6c61a500..4416307ecf 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -893,10 +893,9 @@ impl Tenant { // 1. "Timeline has no ancestor and no layer files" for (timeline_id, local_metadata) in sorted_timelines { - // FIXME should we fail load of whole tenant if one timeline failed? - // consider branch hierarchy. Maybe set one to broken and others to Paused or something self.load_local_timeline(timeline_id, local_metadata) - .await?; + .await + .with_context(|| format!("load local timeline {timeline_id}"))?; } // Start background operations and open the tenant for business.