From 53b837d507dc90a9b9526b20b6d6b8d9f5824c61 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Fri, 11 Apr 2025 13:25:25 +0200 Subject: [PATCH] put in a note on blob_io writer not needed to do owned buffers io anymore --- pageserver/src/tenant/blob_io.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pageserver/src/tenant/blob_io.rs b/pageserver/src/tenant/blob_io.rs index 2f453e9d77..058f42b10c 100644 --- a/pageserver/src/tenant/blob_io.rs +++ b/pageserver/src/tenant/blob_io.rs @@ -205,6 +205,8 @@ impl BlobWriter { ) -> (FullSlice, Result<(), Error>) { let res = self .writer + // TODO: why are we taking a FullSlice if we're going to pass a borrow downstack? + // Can remove all the complexity around owned buffers upstack .write_buffered_borrowed(&src_buf, ctx) .await .map(|len| {