From 5444e6ff324fcf6a2dbc29f701c97c1365d5f6ff Mon Sep 17 00:00:00 2001 From: Bojan Serafimov Date: Thu, 1 Dec 2022 23:04:06 -0500 Subject: [PATCH] Add todo --- pageserver/src/tenant/bst_layer_map.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pageserver/src/tenant/bst_layer_map.rs b/pageserver/src/tenant/bst_layer_map.rs index 5bac17a440..8896197a6b 100644 --- a/pageserver/src/tenant/bst_layer_map.rs +++ b/pageserver/src/tenant/bst_layer_map.rs @@ -32,6 +32,10 @@ impl BSTLM { pub fn insert(self: &mut Self, key_begin: u32, key_end: u32, lsn: u32, value: String) { // TODO check for off-by-one errors + // TODO check if LSN is lower than current max LSN. It should be rare for + // that to happen with image layers, and there are solutions, but it's + // tricky. + // NOTE The order of the following lines is important!! // Preserve information after right endpoint