From 59d197f6f6a3fbbc887f63e24431b775ee742892 Mon Sep 17 00:00:00 2001
From: Conrad Ludgate <conradludgate@gmail.com>
Date: Wed, 16 Oct 2024 12:05:27 +0100
Subject: [PATCH] use pg_quote

---
 compute_tools/src/compute.rs | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/compute_tools/src/compute.rs b/compute_tools/src/compute.rs
index 0d52d61585..81d631fc0a 100644
--- a/compute_tools/src/compute.rs
+++ b/compute_tools/src/compute.rs
@@ -20,7 +20,6 @@ use futures::stream::FuturesUnordered;
 use futures::StreamExt;
 use nix::unistd::Pid;
 use postgres::error::SqlState;
-use postgres::Row;
 use postgres::{Client, NoTls};
 use tracing::{debug, error, info, instrument, warn};
 use utils::id::{TenantId, TimelineId};
@@ -1394,14 +1393,8 @@ LIMIT 100",
             .map(|row| row.get(0));
 
         // sanitize the inputs as postgres idents.
-        // should we instead use `Escaping::pg_quote`?
-        let format_query = "SELECT quote_ident($1) ext_name, quote_ident($2) ext_version";
-        let format: Row = db_client
-            .query_one(format_query, &[&ext_name, &ext_version])
-            .await
-            .with_context(|| format!("Failed to execute query: {}", format_query))?;
-        let ext_name: String = format.get("ext_name");
-        let ext_version: String = format.get("ext_version");
+        let ext_name: String = ext_name.to_string().pg_quote();
+        let ext_version: String = ext_version.to_string().pg_quote();
 
         if let Some(installed_version) = version {
             if installed_version == ext_version {