From 5d12e5a72d0a9fd03425c4a6e785feeae7912b13 Mon Sep 17 00:00:00 2001 From: Konstantin Knizhnik Date: Thu, 10 Oct 2024 17:12:05 +0300 Subject: [PATCH] Update pageserver/src/basebackup.rs Co-authored-by: Heikki Linnakangas --- pageserver/src/basebackup.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pageserver/src/basebackup.rs b/pageserver/src/basebackup.rs index 50e48593d6..7c907e7c6c 100644 --- a/pageserver/src/basebackup.rs +++ b/pageserver/src/basebackup.rs @@ -258,8 +258,7 @@ where async fn send_tarball(mut self) -> Result<(), BasebackupError> { // TODO include checksum - // On normal Postgres shutdown, shutdown checkpoint should be performed and correspondent - // WAL record should be the last record in the WAL. + // Detect if we are creating the basebackup exactly at a shutdown checkpoint. let normal_shutdown = if let Ok(checkpoint_bytes) = self.timeline.get_checkpoint(self.lsn, self.ctx).await {