rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-06 13:02:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix page reconstruct time histo

Browse Source 
Signed-off-by: Dhammika Pathirana <dhammika@gmail.com>
This commit is contained in:
Dhammika Pathirana
2022-03-02 14:50:22 -08:00
parent a8a7dc9ca6
commit 5d7bd8643a
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
pageserver/src/layered_repository.rs
View File

@@ -94,7 +94,7 @@ lazy_static! {
lazy_static! {
static ref RECONSTRUCT_TIME: HistogramVec = register_histogram_vec!(
"pageserver_getpage_reconstruct_time",
"FIXME Time spent on storage operations",
"Time spent on storage operations",
&["tenant_id", "timeline_id"]
)
.expect("failed to define a metric");
@@ -868,8 +868,7 @@ impl Timeline for LayeredTimeline {
let (seg, seg_blknum) = SegmentTag::from_blknum(rel, rel_blknum);
if let Some((layer, lsn)) = self.get_layer_for_read(seg, lsn)? {
self.reconstruct_time_histo
.observe_closure_duration(|| self.materialize_page(seg, seg_blknum, lsn, &*layer))
self.materialize_page(seg, seg_blknum, lsn, &*layer)
} else {
// FIXME: This can happen if PostgreSQL extends a relation but never writes
// the page. See https://github.com/zenithdb/zenith/issues/841
@@ -2022,17 +2021,19 @@ impl LayeredTimeline {
let mut layer_ref = layer;
let mut curr_lsn = lsn;
loop {
let result = layer_ref
.get_page_reconstruct_data(seg_blknum, curr_lsn, &mut data)
.with_context(|| {
format!(
"Failed to get reconstruct data {} {:?} {} {}",
layer_ref.get_seg_tag(),
layer_ref.filename(),
seg_blknum,
curr_lsn,
)
})?;
let result = self.reconstruct_time_histo.observe_closure_duration(|| {
layer_ref
.get_page_reconstruct_data(seg_blknum, curr_lsn, &mut data)
.with_context(|| {
format!(
"Failed to get reconstruct data {} {:?} {} {}",
layer_ref.get_seg_tag(),
layer_ref.filename(),
seg_blknum,
curr_lsn,
)
})
})?;
match result {
PageReconstructResult::Complete => break,
PageReconstructResult::Continue(cont_lsn) => {