diff --git a/.github/workflows/_build-and-test-locally.yml b/.github/workflows/_build-and-test-locally.yml index e2203a38ec..3c2029fcb1 100644 --- a/.github/workflows/_build-and-test-locally.yml +++ b/.github/workflows/_build-and-test-locally.yml @@ -391,10 +391,6 @@ jobs: PAGESERVER_VIRTUAL_FILE_IO_ENGINE: tokio-epoll-uring USE_LFC: ${{ matrix.lfc_state == 'with-lfc' && 'true' || 'false' }} - # Temporary disable this step until we figure out why it's so flaky - # Ref https://github.com/neondatabase/neon/issues/4540 - name: Merge and upload coverage data - if: | - false && - inputs.build-type == 'debug' && matrix.pg_version == 'v16' + if: inputs.build-type == 'debug' uses: ./.github/actions/save-coverage-data diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 456c7b8c92..827a929f02 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -484,21 +484,6 @@ jobs: - name: Merge coverage data run: scripts/coverage "--profraw-prefix=$GITHUB_JOB" --dir=/tmp/coverage merge - - name: Build coverage report - env: - COMMIT_URL: ${{ github.server_url }}/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha || github.sha }} - run: | - scripts/coverage --dir=/tmp/coverage \ - report \ - --input-objects=/tmp/coverage/binaries.list \ - --commit-url=${COMMIT_URL} \ - --format=github - - scripts/coverage --dir=/tmp/coverage \ - report \ - --input-objects=/tmp/coverage/binaries.list \ - --format=lcov - - name: Build coverage report NEW id: upload-coverage-report-new env: @@ -511,6 +496,13 @@ jobs: CURRENT="${COMMIT_SHA}" BASELINE="$(git merge-base $BASE_SHA $CURRENT)" + mkdir /tmp/coverage/report + + scripts/coverage --dir=/tmp/coverage \ + report \ + --input-objects=/tmp/coverage/binaries.list \ + --format=lcov + cp /tmp/coverage/report/lcov.info ./${CURRENT}.info GENHTML_ARGS="--ignore-errors path,unmapped,empty --synthesize-missing --demangle-cpp rustfilt --output-directory lcov-html ${CURRENT}.info"