From 63cbf75b02b39b585d67c4ac610007d0c667207e Mon Sep 17 00:00:00 2001
From: Christian Schwarz <christian@neon.tech>
Date: Tue, 23 Apr 2024 12:42:57 +0000
Subject: [PATCH] clippy & doc check

---
 pageserver/src/tenant/ephemeral_file/sandwich.rs           | 3 +--
 pageserver/src/tenant/ephemeral_file/zero_padded_buffer.rs | 2 +-
 pageserver/src/virtual_file/owned_buffers_io/write.rs      | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/pageserver/src/tenant/ephemeral_file/sandwich.rs b/pageserver/src/tenant/ephemeral_file/sandwich.rs
index db8495f9dc..7bea7d887f 100644
--- a/pageserver/src/tenant/ephemeral_file/sandwich.rs
+++ b/pageserver/src/tenant/ephemeral_file/sandwich.rs
@@ -43,8 +43,7 @@ impl Sandwich {
         let flushed_offset = self.buffered_writer.as_inner().bytes_written();
         let buffer: &zero_padded_buffer::Buf<{ Self::TAIL_SZ }> =
             self.buffered_writer.inspect_buffer();
-        let buffered_offset = flushed_offset + u64::try_from(buffer.pending()).unwrap();
-        buffered_offset
+        flushed_offset + u64::try_from(buffer.pending()).unwrap()
     }
 
     pub(crate) async fn read_blk(&self, blknum: u32) -> Result<ReadResult, std::io::Error> {
diff --git a/pageserver/src/tenant/ephemeral_file/zero_padded_buffer.rs b/pageserver/src/tenant/ephemeral_file/zero_padded_buffer.rs
index c55b7b2e3c..eed0edefb8 100644
--- a/pageserver/src/tenant/ephemeral_file/zero_padded_buffer.rs
+++ b/pageserver/src/tenant/ephemeral_file/zero_padded_buffer.rs
@@ -75,7 +75,7 @@ impl<const N: usize> crate::virtual_file::owned_buffers_io::write::Buffer for Bu
     }
 }
 
-/// We have this implementation so that Buf<N> can be used with [`crate::virtual_file::owned_buffers_io::BufferedWriter`].
+/// We have this implementation so that [`Buf<N>`] can be used with [`crate::virtual_file::owned_buffers_io::write::BufferedWriter`].
 ///
 ///
 /// SAFETY:
diff --git a/pageserver/src/virtual_file/owned_buffers_io/write.rs b/pageserver/src/virtual_file/owned_buffers_io/write.rs
index 6d84341929..7f30ea2fe1 100644
--- a/pageserver/src/virtual_file/owned_buffers_io/write.rs
+++ b/pageserver/src/virtual_file/owned_buffers_io/write.rs
@@ -38,7 +38,7 @@ impl Buffer for BytesMut {
     }
 
     fn flush(self) -> Slice<BytesMut> {
-        if self.len() == 0 {
+        if self.is_empty() {
             return self.slice_full();
         }
         let len = self.len();