From 649f324fe3b7dc5ff8b95cfaabf584753d53af16 Mon Sep 17 00:00:00 2001 From: Dmitry Rodionov Date: Wed, 30 Mar 2022 13:46:18 +0300 Subject: [PATCH] make logging in basebackup more consistent --- pageserver/src/basebackup.rs | 1 + pageserver/src/page_service.rs | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pageserver/src/basebackup.rs b/pageserver/src/basebackup.rs index e2a56f17d6..3caf27b9b3 100644 --- a/pageserver/src/basebackup.rs +++ b/pageserver/src/basebackup.rs @@ -65,6 +65,7 @@ impl<'a> Basebackup<'a> { // prev_lsn to Lsn(0) if we cannot provide the correct value. let (backup_prev, backup_lsn) = if let Some(req_lsn) = req_lsn { // Backup was requested at a particular LSN. Wait for it to arrive. + info!("waiting for {}", req_lsn); timeline.tline.wait_lsn(req_lsn)?; // If the requested point is the end of the timeline, we can diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs index 43e1ec275d..e7a4117b3e 100644 --- a/pageserver/src/page_service.rs +++ b/pageserver/src/page_service.rs @@ -514,6 +514,7 @@ impl PageServerHandler { ) -> anyhow::Result<()> { let span = info_span!("basebackup", timeline = %timelineid, tenant = %tenantid, lsn = field::Empty); let _enter = span.enter(); + info!("starting"); // check that the timeline exists let timeline = tenant_mgr::get_timeline_for_tenant_load(tenantid, timelineid) @@ -536,7 +537,7 @@ impl PageServerHandler { basebackup.send_tarball()?; } pgb.write_message(&BeMessage::CopyDone)?; - debug!("CopyDone sent!"); + info!("done"); Ok(()) }