From 6b615cbde183a78c2cd1c77d8e7a9f57801f8ddd Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Thu, 27 May 2021 23:16:54 +0300 Subject: [PATCH] Remove Copy marker from large ServerInfo struct. We don't want to encourage passing it by value. Doesn't matter much in practice, but let's be tidy. Per discussion at https://github.com/zenithdb/zenith/pull/195#issuecomment-849897327 --- walkeeper/src/receive_wal.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/walkeeper/src/receive_wal.rs b/walkeeper/src/receive_wal.rs index b3a20fa1d0..8f22c44a55 100644 --- a/walkeeper/src/receive_wal.rs +++ b/walkeeper/src/receive_wal.rs @@ -36,7 +36,7 @@ pub struct NodeId { uuid: [u8; 16], } -#[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize)] +#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] pub struct ServerInfo { /// proxy-safekeeper protocol version pub protocol_version: u32, @@ -220,7 +220,7 @@ impl ReceiveWalConn { /* Update information about server, but preserve locally stored node_id */ let node_id = my_info.server.node_id; - my_info.server = server_info; + my_info.server = server_info.clone(); my_info.server.node_id = node_id; /* Calculate WAL end based on local data */