rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2025-12-23 06:09:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix nightly lints (#12746)

Browse Source 
- Remove some unused code
- Use `is_multiple_of()` instead of '%'
- Collapse consecuative "if let" statements
- Elided lifetime fixes

It is enough just to review the code of your team
This commit is contained in:
Ivan Efremov
2025-07-29 00:36:30 +03:00
committed by GitHub
parent fe7a4e1ab6
commit 6be572177c
6 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/http-utils/src/endpoint.rs
View File

@@ -558,12 +558,12 @@ async fn add_request_id_header_to_response(
mut res: Response<Body>, mut res: Response<Body>,
req_info: RequestInfo, req_info: RequestInfo,
) -> Result<Response<Body>, ApiError> { ) -> Result<Response<Body>, ApiError> {
if let Some(request_id) = req_info.context::<RequestId>() { if let Some(request_id) = req_info.context::<RequestId>()
if let Ok(request_header_value) = HeaderValue::from_str(&request_id.0) { && let Ok(request_header_value) = HeaderValue::from_str(&request_id.0)
{
res.headers_mut() res.headers_mut()
.insert(&X_REQUEST_ID_HEADER, request_header_value); .insert(&X_REQUEST_ID_HEADER, request_header_value);
}; };
};
Ok(res) Ok(res)
} }

6
libs/http-utils/src/server.rs
View File

@@ -72,11 +72,11 @@ impl Server {
if err.is_incomplete_message() || err.is_closed() || err.is_timeout() { if err.is_incomplete_message() || err.is_closed() || err.is_timeout() {
return true; return true;
} }
if let Some(inner) = err.source() { if let Some(inner) = err.source()
if let Some(io) = inner.downcast_ref::<std::io::Error>() { && let Some(io) = inner.downcast_ref::<std::io::Error>()
{
return suppress_io_error(io); return suppress_io_error(io);
} }
}
false false
} }

2
libs/neon-shmem/src/hash.rs
View File

@@ -363,7 +363,7 @@ where
// TODO: An Iterator might be nicer. The communicator's clock algorithm needs to // TODO: An Iterator might be nicer. The communicator's clock algorithm needs to
// _slowly_ iterate through all buckets with its clock hand, without holding a lock. // _slowly_ iterate through all buckets with its clock hand, without holding a lock.
// If we switch to an Iterator, it must not hold the lock. // If we switch to an Iterator, it must not hold the lock.
pub fn get_at_bucket(&self, pos: usize) -> Option<ValueReadGuard<(K, V)>> { pub fn get_at_bucket(&self, pos: usize) -> Option<ValueReadGuard<'_, (K, V)>> {
let map = unsafe { self.shared_ptr.as_ref() }.unwrap().read(); let map = unsafe { self.shared_ptr.as_ref() }.unwrap().read();
if pos >= map.buckets.len() { if pos >= map.buckets.len() {
return None; return None;

2
libs/tracing-utils/src/perf_span.rs
View File

@@ -49,7 +49,7 @@ impl PerfSpan {
} }
} }
pub fn enter(&self) -> PerfSpanEntered { pub fn enter(&self) -> PerfSpanEntered<'_> {
if let Some(ref id) = self.inner.id() { if let Some(ref id) = self.inner.id() {
self.dispatch.enter(id); self.dispatch.enter(id);
} }

8
proxy/src/metrics.rs
View File

@@ -553,14 +553,6 @@ impl From<bool> for Bool {
} }
} }
#[derive(LabelGroup)]
#[label(set = InvalidEndpointsSet)]
pub struct InvalidEndpointsGroup {
pub protocol: Protocol,
pub rejected: Bool,
pub outcome: ConnectOutcome,
}
#[derive(LabelGroup)] #[derive(LabelGroup)]
#[label(set = RetriesMetricSet)] #[label(set = RetriesMetricSet)]
pub struct RetriesMetricGroup { pub struct RetriesMetricGroup {

2
proxy/src/stream.rs
View File

@@ -102,7 +102,7 @@ pub struct ReportedError {
} }
impl ReportedError { impl ReportedError {
pub fn new(e: (impl UserFacingError + Into<anyhow::Error>)) -> Self { pub fn new(e: impl UserFacingError + Into<anyhow::Error>) -> Self {
let error_kind = e.get_error_kind(); let error_kind = e.get_error_kind();
Self { Self {
source: e.into(), source: e.into(),