From 6f50bec781aacfd4a2ae52f75301ebfc8f88e99f Mon Sep 17 00:00:00 2001 From: Alex Chi Date: Tue, 27 Jun 2023 10:24:48 -0400 Subject: [PATCH] fix merge conflicts Signed-off-by: Alex Chi --- pageserver/src/tenant/layer_cache.rs | 5 +++-- pageserver/src/tenant/layer_map.rs | 4 ---- pageserver/src/tenant/timeline.rs | 4 ++-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/pageserver/src/tenant/layer_cache.rs b/pageserver/src/tenant/layer_cache.rs index 060cfa09d8..8c1c584895 100644 --- a/pageserver/src/tenant/layer_cache.rs +++ b/pageserver/src/tenant/layer_cache.rs @@ -1,6 +1,7 @@ use super::storage_layer::{PersistentLayer, PersistentLayerDesc, PersistentLayerKey, RemoteLayer}; use super::Timeline; -use crate::tenant::layer_map::{self, LayerMap}; +use crate::tenant::layer_map::{ LayerMap}; +use crate::tenant::timeline::compare_arced_layers; use anyhow::Result; use std::sync::{Mutex, Weak}; use std::{collections::HashMap, sync::Arc}; @@ -114,7 +115,7 @@ impl LayerCache { if let Some(layer) = guard.get_mut(&expected.layer_desc().key()) { anyhow::ensure!( - layer_map::compare_arced_layers(&expected, layer), + compare_arced_layers(&expected, layer), "replacing downloaded layer into layermap failed because another layer was found instead of expected, expected={expected:?}, new={new:?}", expected = Arc::as_ptr(&expected), new = Arc::as_ptr(layer), diff --git a/pageserver/src/tenant/layer_map.rs b/pageserver/src/tenant/layer_map.rs index b4ba8dae2b..efb21fdfa7 100644 --- a/pageserver/src/tenant/layer_map.rs +++ b/pageserver/src/tenant/layer_map.rs @@ -658,10 +658,6 @@ mod tests { mod l0_delta_layers_updated { - use crate::tenant::{ - storage_layer::{PersistentLayer, PersistentLayerDesc}, - timeline::LayerFileManager, - }; use crate::tenant::storage_layer::{PersistentLayer, PersistentLayerDesc}; use super::*; diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs index 77411347fd..314919e334 100644 --- a/pageserver/src/tenant/timeline.rs +++ b/pageserver/src/tenant/timeline.rs @@ -123,7 +123,7 @@ impl PartialOrd for Hole { pub struct LayerFileManager(()); -impl LayerMapping { +impl LayerFileManager { pub(crate) fn new() -> Self { Self(()) } @@ -152,7 +152,7 @@ pub struct Timeline { pub pg_version: u32, - pub(crate) layers: tokio::sync::RwLock<(LayerMap, LayerMapping)>, + pub(crate) layers: Arc>, pub(super) lcache: LayerCache,