From 704d4f4640b77c29e337a65295ca50f7871b7444 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Tue, 28 Mar 2023 18:06:44 +0200 Subject: [PATCH] doc: improve comment on min_resident_size --- pageserver/src/disk_usage_eviction_task.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pageserver/src/disk_usage_eviction_task.rs b/pageserver/src/disk_usage_eviction_task.rs index 5079e11f77..145dff1880 100644 --- a/pageserver/src/disk_usage_eviction_task.rs +++ b/pageserver/src/disk_usage_eviction_task.rs @@ -559,9 +559,9 @@ async fn collect_eviction_candidates( // `min_resident_size` defaults to maximum layer file size of the tenant. // This ensures that each tenant can have at least one layer resident at a given time, // ensuring forward progress for a single Timeline::get in that tenant. - // It's a questionable heuristic since there are many Timeline::get - // requests going on and multiple layers are needed, and, at least in Neon prod, - // the median layer file size is much smaller than the compaction target size. + // It's a questionable heuristic since, usually, there are many Timeline::get + // requests going on for a tenant, and, at least in Neon prod, the median + // layer file size is much smaller than the compaction target size. // We could be better here, e.g., sum of all L0 layers + most recent L1 layer. // That's what's typically used by the various background loops. //