From 71f9d9e5a32a4afc42071849a9fe0380ce0e560f Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Thu, 10 Aug 2023 15:55:41 +0300 Subject: [PATCH] test: allow slow shutdown warning (#4953) Introduced in #4886, did not consider that tests with real_s3 could sometimes go over the limit. Do not fail tests because of that. --- pageserver/src/lib.rs | 1 + test_runner/fixtures/neon_fixtures.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/pageserver/src/lib.rs b/pageserver/src/lib.rs index a3a9497d57..7acf7ed5d8 100644 --- a/pageserver/src/lib.rs +++ b/pageserver/src/lib.rs @@ -226,6 +226,7 @@ async fn timed( let ret = fut.await; + // this has a global allowed_errors tracing::warn!( task = name, elapsed_ms = started.elapsed().as_millis(), diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index 901049188e..a15c3724be 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -1518,6 +1518,8 @@ class NeonPageserver(PgProtocol): # Pageserver timeline deletion should be polled until it gets 404, so ignore it globally ".*Error processing HTTP request: NotFound: Timeline .* was not found", ".*took more than expected to complete.*", + # these can happen during shutdown, but it should not be a reason to fail a test + ".*completed, took longer than expected.*", ] def start(