From 72ef59c37860f9060ddfcbfa29e85a60a0e43d8a Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Mon, 13 Dec 2021 13:44:08 +0200 Subject: [PATCH] Fix small typos in comments, add a comment. The introducing paragraph README could use some more love, but let's at least fix the typos. --- README.md | 2 +- pageserver/README.md | 2 +- pageserver/src/layered_repository.rs | 1 + test_runner/performance/test_write_amplification.py | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index aab954c346..b2a74c1eee 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Zenith -Zenith is an serverless open source alternative to AWS Aurora Postgres. It separates storage and compute and substitutes PostgreSQL storage layer by redistributes data across a cluster of nodes. +Zenith is a serverless open source alternative to AWS Aurora Postgres. It separates storage and compute and substitutes PostgreSQL storage layer by redistributing data across a cluster of nodes. ## Architecture overview diff --git a/pageserver/README.md b/pageserver/README.md index 7d1758b1dc..89ea0f12fd 100644 --- a/pageserver/README.md +++ b/pageserver/README.md @@ -138,7 +138,7 @@ CLI examples: * AWS S3 : `${PAGESERVER_BIN} --remote-storage-s3-bucket="some-sample-bucket" --remote-storage-region="eu-north-1" --remote-storage-access-key="SOMEKEYAAAAASADSAH*#" --remote-storage-secret-access-key="SOMEsEcReTsd292v"` For Amazon AWS S3, a key id and secret access key could be located in `~/.aws/credentials` if awscli was ever configured to work with the desired bucket, on the AWS Settings page for a certain user. Also note, that the bucket names does not contain any protocols when used on AWS. -For local S3 installations, refer to the their documentation for name format and credentials. +For local S3 installations, refer to their documentation for name format and credentials. Similar to other pageserver settings, toml config file can be used to configure either of the storages as backup targets. Required sections are: diff --git a/pageserver/src/layered_repository.rs b/pageserver/src/layered_repository.rs index 646b4fee06..0703da73ea 100644 --- a/pageserver/src/layered_repository.rs +++ b/pageserver/src/layered_repository.rs @@ -78,6 +78,7 @@ use storage_layer::{ Layer, PageReconstructData, PageReconstructResult, SegmentTag, RELISH_SEG_SIZE, }; +// re-export this function so that page_cache.rs can use it. pub use crate::layered_repository::ephemeral_file::writeback as writeback_ephemeral_file; static ZERO_PAGE: Bytes = Bytes::from_static(&[0u8; 8192]); diff --git a/test_runner/performance/test_write_amplification.py b/test_runner/performance/test_write_amplification.py index 46e8ac5266..8d4ac882a1 100644 --- a/test_runner/performance/test_write_amplification.py +++ b/test_runner/performance/test_write_amplification.py @@ -69,7 +69,7 @@ def test_write_amplification(zenith_simple_env: ZenithEnv, zenbenchmark): # more memory isn't the right solution. We could # demonstrate the effect also by generating the WAL # slower, adding some delays in this loop. But forcing - # the the checkpointing and GC makes the test go faster, + # the checkpointing and GC makes the test go faster, # with the same total I/O effect. pscur.execute(f"do_gc {env.initial_tenant} {timeline} 0")