From 73d7a9bc6e734559d37c8f97d9cf2ea61da40dce Mon Sep 17 00:00:00 2001 From: Arthur Petukhovsky Date: Thu, 10 Aug 2023 22:38:22 +0200 Subject: [PATCH] proxy: propagate ws span (#4966) Found this log on staging: ``` 2023-08-10T17:42:58.573790Z INFO handling interactive connection from client protocol="ws" ``` We seem to be losing websocket span in spawn, this patch fixes it. --- proxy/src/http/websocket.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/proxy/src/http/websocket.rs b/proxy/src/http/websocket.rs index fec76c74f4..071382cfb9 100644 --- a/proxy/src/http/websocket.rs +++ b/proxy/src/http/websocket.rs @@ -187,12 +187,16 @@ async fn ws_handler( let (response, websocket) = hyper_tungstenite::upgrade(&mut request, None) .map_err(|e| ApiError::BadRequest(e.into()))?; - tokio::spawn(async move { - if let Err(e) = serve_websocket(websocket, config, &cancel_map, session_id, host).await - { - error!(session_id = ?session_id, "error in websocket connection: {e:?}"); + tokio::spawn( + async move { + if let Err(e) = + serve_websocket(websocket, config, &cancel_map, session_id, host).await + { + error!(session_id = ?session_id, "error in websocket connection: {e:?}"); + } } - }); + .in_current_span(), + ); // Return the response so the spawned future can continue. Ok(response)