From 761644af25b1cc831d042a0985adffed02811aa1 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Mon, 21 Aug 2023 09:43:18 +0300 Subject: [PATCH] dube: adjust comments --- pageserver/src/disk_usage_eviction_task.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pageserver/src/disk_usage_eviction_task.rs b/pageserver/src/disk_usage_eviction_task.rs index 92e90a835d..12de754c2b 100644 --- a/pageserver/src/disk_usage_eviction_task.rs +++ b/pageserver/src/disk_usage_eviction_task.rs @@ -349,10 +349,10 @@ pub async fn disk_usage_eviction_task_iteration_impl( let batch = batched.entry(TimelineKey(candidate.timeline)).or_default(); + // semaphore will later be used to limit eviction concurrency, and we can express at + // most u32 number of permits. unlikely we would have u32::MAX layers to be evicted, + // but fail gracefully by not making batches larger. if batch.len() < u32::MAX as usize { - // semaphore will later be used to limit eviction concurrency, and we can express at - // most u32 number of permits. unlikely we would have u32::MAX layers to be evicted, - // but fail gracefully. batch.push(candidate.layer); max_batch_size = max_batch_size.max(batch.len()); } @@ -397,7 +397,7 @@ pub async fn disk_usage_eviction_task_iteration_impl( let mut evictions_failed = LayerCount::default(); let Ok(_permit) = limit.acquire_many_owned(batch_size).await else { - // assume semaphore closing means cancelled + // semaphore closing means cancelled return (evicted_bytes, evictions_failed); };