python: more linting (#4734)

Ruff has "B" class of lints, including B018 which will nag on useless
expressions, related to #4719. Enable such lints and fix the existing
issues.

Most notably:
- https://beta.ruff.rs/docs/rules/mutable-argument-default/
- https://beta.ruff.rs/docs/rules/assert-false/

---------

Co-authored-by: Alexander Bayandin <alexander@neon.tech>
This commit is contained in:
Joonas Koivunen
2023-07-18 12:56:40 +03:00
committed by GitHub
parent 2e8a3afab1
commit 762a8a7bb5
37 changed files with 87 additions and 83 deletions

View File

@@ -133,7 +133,7 @@ def test_read_validation(neon_simple_env: NeonEnv):
log.info("Validation page inspect won't allow reading pages of dropped relations")
try:
c.execute("select * from page_header(get_raw_page('foo', 'main', 0));")
assert False, "query should have failed"
raise AssertionError("query should have failed")
except UndefinedTable as e:
log.info("Caught an expected failure: {}".format(e))
@@ -157,7 +157,7 @@ def test_read_validation_neg(neon_simple_env: NeonEnv):
c.execute(
"select lsn, lower, upper from page_header(get_raw_page_at_lsn('Unknown', 'main', 0, '0/0'))"
)
assert False, "query should have failed"
raise AssertionError("query should have failed")
except UndefinedTable as e:
log.info("Caught an expected failure: {}".format(e))
@@ -169,7 +169,7 @@ def test_read_validation_neg(neon_simple_env: NeonEnv):
c.execute(
"select lsn, lower, upper from page_header(get_raw_page_at_lsn('foo', 'main', 0, '0/0'))"
)
assert False, "query should have failed"
raise AssertionError("query should have failed")
except IoError as e:
log.info("Caught an expected failure: {}".format(e))