From 7e6b8abf46715ed9273ccab2869a3c6e788d199d Mon Sep 17 00:00:00 2001 From: Vlad Lazar Date: Thu, 20 Jun 2024 10:59:25 +0100 Subject: [PATCH] tests: check consistency after fill --- test_runner/performance/test_storage_controller_scale.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test_runner/performance/test_storage_controller_scale.py b/test_runner/performance/test_storage_controller_scale.py index f65410bb98..40da23b5ac 100644 --- a/test_runner/performance/test_storage_controller_scale.py +++ b/test_runner/performance/test_storage_controller_scale.py @@ -300,9 +300,6 @@ def test_storage_controller_many_tenants( ps.restart() poll_node_status(env, ps.id, "Active", max_attempts=24, backoff=1) - env.storage_controller.reconcile_until_idle() - env.storage_controller.consistency_check() - retryable_node_operation( lambda ps_id: env.storage_controller.node_fill(ps_id), ps.id, max_attempts=3, backoff=2 ) @@ -313,6 +310,9 @@ def test_storage_controller_many_tenants( assert_consistent_balanced_attachments(env, total_shards) + env.storage_controller.reconcile_until_idle() + env.storage_controller.consistency_check() + # Consistency check is safe here: restarting pageservers should not have caused any Reconcilers to spawn, # as they were not offline long enough to trigger any scheduling changes. env.storage_controller.consistency_check()